Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Orchard value in balance API & add Orchard components to ScannedBlock #1057

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Expose Orchard value in balance API & add Orchard components to ScannedBlock #1057

merged 3 commits into from
Dec 5, 2023

Conversation

nuttycom
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited
Loading

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (764127f) 70.62% compared to head (9aec53e) 70.56%.
Report is 5 commits behind head on main.

❗ Current head 9aec53e differs from pull request most recent head 214a375. Consider uploading reports for the commit 214a375 to get more accurate results

Files Patch % Lines
zcash_client_backend/src/data_api.rs 17.64% 14 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1057      +/-   ##
==========================================
- Coverage   70.62%   70.56%   -0.07%     
==========================================
  Files         140      140              
  Lines       13786    13801      +15     
==========================================
+ Hits         9737     9738       +1     
- Misses       4049     4063      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

str4d
str4d requested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9aec53e.

zcash_client_backend/src/data_api.rs Outdated Show resolved Hide resolved
zcash_client_backend/src/data_api.rs Show resolved Hide resolved
zcash_client_backend/src/data_api.rs Show resolved Hide resolved
zcash_client_backend/src/data_api.rs Show resolved Hide resolved
zcash_client_backend/src/data_api.rs Show resolved Hide resolved
zcash_client_backend/src/data_api.rs Outdated Show resolved Hide resolved
@nuttycom
zcash_client_backend: Make Balance and AccountBalance fields priv…
214a375 
…ate.

Public methods for mutation of these fields have been provided that
perform checking for overflow of the valid monetary range as part
of their operation.
@nuttycom nuttycom requested a review from str4d December 4, 2023 21:13
str4d
str4d approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 214a375

@str4d str4d merged commit fb42436 into zcash:main Dec 5, 2023
14 checks passed
@nuttycom nuttycom deleted the wallet/orchard_balance branch December 5, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@str4d str4d str4d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nuttycom @str4d