zcash_client_backend: Allow sharing instances of ScanningKeys between threads
#1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bound `ScanningKeyOps` by `Send + Sync` so `ScanningKeys` auto-implements `Send` and `Sync` instead of `!Send` and `!Sync`.
upbqdn
force-pushed
the
scanning_keys_send
branch
from
9669142
to
99dfbb9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1400 +/- ##
=======================================
Coverage 63.13% 63.13%
=======================================
Files 126 126
Lines 14720 14720
=======================================
Hits 9293 9293
Misses 5427 5427 ☔ View full report in Codecov by Sentry. |
str4d
reviewed
Jul 9, 2024
| @@ -120,7 +120,7 @@ pub struct ScanningKey<Ivk, Nk, AccountId> { | |||
| key_scope: Option<Scope>, | |||
| } | |||
|
|
|||
| impl<AccountId> ScanningKeyOps<SaplingDomain, AccountId, sapling::Nullifier> | |||
| impl<AccountId: Send + Sync> ScanningKeyOps<SaplingDomain, AccountId, sapling::Nullifier> | |||
There was a problem hiding this comment.
Is this bound (repeated everywhere) avoidable if we add the equivalent bound on AccountId in ScanningKeyOps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It would be handy if Zebra could share instances of
ScanningKeysbetween threads.Solution
ScanningKeyOpsbySend + SyncsoScanningKeysauto-implementsSendandSyncinstead of!Sendand!Sync.