Fix update_chain_tip bugs
#932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kris Nuttycombe <[email protected]>
daira
reviewed
Sep 2, 2023
daira
reviewed
Sep 2, 2023
daira
reviewed
Sep 2, 2023
daira
reviewed
Sep 2, 2023
The pre-refactor code did this correctly, but the comment was moved without fully moving the logic.
Co-authored-by: Daira Emma Hopwood <[email protected]>
We should do those in a separate PR (as this PR is fixing specific bugs). |
nuttycom
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.