Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --nocache option to disable compact block file cache #483

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

LarryRuane
Copy link
Collaborator

Closes #480. Enabling this option decreases the performance of gRPCs GetBlock and GetBlockRange, but conserves disk space (the current database size is about 17GB).

Note, specifying this option will also delete the existing cache (so if you start again without --nocache, the cache will need to be recreated).

Copy link

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

The changes here look good to me, and are exactly what I had in mind.

cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
@LarryRuane
Copy link
Collaborator Author

LarryRuane commented Jun 13, 2024

Force pushed review suggestion, thanks @arya2. Perhaps you can review again and approve? I think this is ready to be merged.

Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@arya2
Copy link

arya2 commented Jun 20, 2024

@daira it looks like it should be okay to merge this and #476 based on the CONTRIBUTING.md, but, just in case, could you kindly confirm that we haven't missed any steps?

(My approval was also a utACK)

This fixes issue zcash#480. Enabling this option decreases the performance of
gRPCs GetBlock and GetBlockRange, but conserves disk space (the size of
the database is currently around 17GB).

Note, specifying this option will also delete the existing cache (so if
you start again without --nocache, the cache will need to be recreated).
@LarryRuane
Copy link
Collaborator Author

Force pushed to rebase

@LarryRuane LarryRuane merged commit 6e3816b into zcash:master Jun 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to disable caching so lightwalletd always gets data from node RPCs
3 participants