Add debug logging to gRPC entrypoints #494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This additional logging may help with debugging lightwalletd clients as
it may isolate the problem to the client or server (lightwalletd) side.
To see entrypoint logging, you must start lightwalletd with the option
--log-level 5 (which is "debug"; the default is 4, which is "info")).
This option shouldn't be used in normal operation, because clients could
flood the log, causing crashes due to running out of disk space. Only
use this when actually debugging or testing.
For most gRPCs, also log return values if the log-level is 6 ("trace").
Return value logging isn't done if there is an error (it's assumed that
the client will log something) or if the output might be very large (we
don't want to overrun the log file).
Enabling trace (--log-level 6) enables everything below that level,
so entry logging is enabled as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This additional logging may help with debugging lightwalletd clients as it may isolate the problem to the client or server (lightwalletd) side.
To see entrypoint logging, you must start lightwalletd with the option --log-level 5 (which is "debug"; the default is 4, which is "info")).
This option shouldn't be used in normal operation, because clients could flood the log, causing crashes due to running out of disk space. Only use this when actually debugging or testing.
For most gRPCs, also log return values if the log-level is 6 ("trace"). Return value logging isn't done if there is an error (it's assumed that the client will log something) or if the output might be very large (we don't want to overrun the log file).
Enabling trace (--log-level 6) enables everything below that level, so entry logging is enabled as well.
Closes #492.