usage of `Iterator::fold` on a type that implements `Try`

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

doc list item without indentation

doc list item without indentation

doc list item without indentation

doc list item without indentation

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

the borrowed expression implements the required traits

usage of `Iterator::fold` on a type that implements `Try`

usage of `Iterator::fold` on a type that implements `Try`

12 warnings emitted

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:534:14 | 534 | .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `#[warn(clippy::manual_try_fold)]` on by default

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/builder.rs:615:18 | 615 | .zip(indexed_outputs.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `indexed_outputs` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/2059132d3c715514da0e4f9cd395a708e666e306/library/core/src/iter/traits/iterator.rs:603:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:638:10 | 638 | .fold(Some(ValueSum::zero()), |acc, action| { | __________^ 639 | | acc? + action.value_sum() 640 | | }) | |__________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

warning: doc list item without indentation --> src/bundle/commitments.rs:19:5 | 19 | /// with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION | ^^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 19 | /// with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION | +

warning: doc list item without indentation --> src/bundle/commitments.rs:21:5 | 21 | /// with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION | ^^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 21 | /// with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION | +

warning: doc list item without indentation --> src/bundle/commitments.rs:23:5 | 23 | /// with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION | ^^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 23 | /// with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION | +

warning: doc list item without indentation --> src/bundle/commitments.rs:24:5 | 24 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244] | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 24 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244] | +++

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/note_encryption.rs:244:18 | 244 | .zip(ephemeral_keys.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/2059132d3c715514da0e4f9cd395a708e666e306/library/core/src/iter/traits/iterator.rs:603:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: non-canonical implementation of `partial_cmp` on an `Ord` type --> src/primitives/redpallas.rs:102:1 | 102 | / impl<T: SigType> PartialOrd for VerificationKey<T> { 103 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 104 | || <[u8; 32]>::from(self).partial_cmp(&<[u8; 32]>::from(other)) 105 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 106 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default