Expose num_actions as a method on PaddingRule
#235
nuttycomAnnotations
2 errors and 14 warnings
|
/home/runner/work/orchard/orchard/src/lib.rs#L50
missing documentation for a method
|
|
missing documentation for a method:
src/lib.rs#L50
error: missing documentation for a method
--> src/builder.rs:50:5
|
50 | pub fn num_actions(&self, num_spends: usize, num_recipients: usize) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> src/lib.rs:16:9
|
16 | #![deny(missing_docs)]
| ^^^^^^^^^^^^
|
|
/home/runner/work/orchard/orchard/src/lib.rs#L6
unused import: `H`
|
|
/home/runner/work/orchard/orchard/src/lib.rs#L418
usage of `Iterator::fold` on a type that implements `Try`
|
|
/home/runner/work/orchard/orchard/src/lib.rs#L456
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
|
|
/home/runner/work/orchard/orchard/src/lib.rs#L246
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
|
|
/home/runner/work/orchard/orchard/src/lib.rs#L195
usage of `Iterator::fold` on a type that implements `Try`
|
|
/home/runner/work/orchard/orchard/src/lib.rs#L201
usage of `Iterator::fold` on a type that implements `Try`
|
|
unused import: `H`:
src/lib.rs#L6
warning: unused import: `H`
--> src/constants.rs:6:91
|
6 | pub use fixed_bases::{NullifierK, OrchardFixedBases, OrchardFixedBasesFull, ValueCommitV, H};
| ^
|
= note: `#[warn(unused_imports)]` on by default
|
|
usage of `Iterator::fold` on a type that implements `Try`:
src/lib.rs#L418
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/builder.rs:418:14
|
418 | .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `#[warn(clippy::manual_try_fold)]` on by default
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/lib.rs#L456
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/builder.rs:456:22
|
456 | .zip(self.recipients.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `self.recipients`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/1a06ac5b5d7c9331e8de1aa1fd7e9d3533034b44/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
usage of `Iterator::fold` on a type that implements `Try`:
src/lib.rs#L468
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/builder.rs:468:14
|
468 | .fold(Some(ValueSum::zero()), |acc, action| {
| ______________^
469 | | acc? + action.value_sum()
470 | | })
| |______________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/lib.rs#L246
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/note_encryption.rs:246:18
|
246 | .zip(ephemeral_keys.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/1a06ac5b5d7c9331e8de1aa1fd7e9d3533034b44/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
non-canonical implementation of `partial_cmp` on an `Ord` type:
src/lib.rs#L102
warning: non-canonical implementation of `partial_cmp` on an `Ord` type
--> src/primitives/redpallas.rs:102:1
|
102 | / impl<T: SigType> PartialOrd for VerificationKey<T> {
103 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
| | _____________________________________________________________-
104 | || <[u8; 32]>::from(self).partial_cmp(&<[u8; 32]>::from(other))
105 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
106 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
= note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default
|
|
usage of `Iterator::fold` on a type that implements `Try`:
src/lib.rs#L195
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/value.rs:195:14
|
195 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + *v).ok_or(OverflowError))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
usage of `Iterator::fold` on a type that implements `Try`:
src/lib.rs#L201
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/value.rs:201:14
|
201 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + v).ok_or(OverflowError))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|