the item `RangeConstrained` is imported redundantly

the item `Value` is imported redundantly

unused import: `H`

the item `Ord` is imported redundantly

the item `PartialOrd` is imported redundantly

usage of `Iterator::fold` on a type that implements `Try`

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

usage of `Iterator::fold` on a type that implements `Try`

usage of `Iterator::fold` on a type that implements `Try`

12 warnings emitted

warning: the item `RangeConstrained` is imported redundantly --> src/circuit/commit_ivk.rs:231:80 | 231 | use halo2_gadgets::utilities::{lookup_range_check::LookupRangeCheckConfig, RangeConstrained}; | ^^^^^^^^^^^^^^^^ ... 234 | use super::*; | -------- the item `RangeConstrained` is already imported here | = note: `#[warn(unused_imports)]` on by default

warning: the item `Value` is imported redundantly --> src/circuit/note_commit.rs:1565:39 | 1565 | use halo2_proofs::circuit::{Chip, Value}; | ^^^^^ 1566 | 1567 | use super::*; | -------- the item `Value` is already imported here

warning: unused import: `H` --> src/constants.rs:6:91 | 6 | pub use fixed_bases::{NullifierK, OrchardFixedBases, OrchardFixedBasesFull, ValueCommitV, H}; | ^

warning: the item `Ord` is imported redundantly --> src/primitives/redpallas.rs:3:17 | 3 | use core::cmp::{Ord, Ordering, PartialOrd}; | ^^^ --> /rustc/277d06bc95c6c38a2337ccde798b2c709384bd84/library/std/src/prelude/mod.rs:125:13 | = note: the item `Ord` is already defined here

warning: the item `PartialOrd` is imported redundantly --> src/primitives/redpallas.rs:3:32 | 3 | use core::cmp::{Ord, Ordering, PartialOrd}; | ^^^^^^^^^^ --> /rustc/277d06bc95c6c38a2337ccde798b2c709384bd84/library/std/src/prelude/mod.rs:125:13 | = note: the item `PartialOrd` is already defined here

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:534:14 | 534 | .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `#[warn(clippy::manual_try_fold)]` on by default

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/builder.rs:615:18 | 615 | .zip(indexed_outputs.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `indexed_outputs` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/277d06bc95c6c38a2337ccde798b2c709384bd84/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:638:10 | 638 | .fold(Some(ValueSum::zero()), |acc, action| { | __________^ 639 | | acc? + action.value_sum() 640 | | }) | |__________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/note_encryption.rs:244:18 | 244 | .zip(ephemeral_keys.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/277d06bc95c6c38a2337ccde798b2c709384bd84/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: non-canonical implementation of `partial_cmp` on an `Ord` type --> src/primitives/redpallas.rs:102:1 | 102 | / impl<T: SigType> PartialOrd for VerificationKey<T> { 103 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 104 | || <[u8; 32]>::from(self).partial_cmp(&<[u8; 32]>::from(other)) 105 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 106 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default

the item `RangeConstrained` is imported redundantly

the item `Value` is imported redundantly

unused import: `H`

the item `Ord` is imported redundantly

the item `PartialOrd` is imported redundantly

usage of `Iterator::fold` on a type that implements `Try`

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

usage of `Iterator::fold` on a type that implements `Try`

usage of `Iterator::fold` on a type that implements `Try`