feat: add option to hide menubar #1441
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! I've been meaning to implement this by copying behavior from Firefox. The menu bar is not very useful as #1251 rightfully stated. I'd go further and hide it by default. Then rely on F10 to either show and focus the menu bar, or just focus when it's visible. Adding a submenu in a menu with a single item may seem to be an overkill, but that's where zoom options for #1256 should also go. Would you be willing to update PR with a similar UX?
|
|
Hey there! Of course, I'd love to contribute with that. |
trollixx
force-pushed
the
add-hide-menubar
branch
from
6baf948 to
01343e9
Compare
trollixx
force-pushed
the
add-hide-menubar
branch
from
01343e9 to
07bdc91
Compare
Add a "View" submenu to the menubar, that allows the user hide the menubar. Also add a keyboard shortcut (Ctrl + M) to toggle the visibility of the menubar. This preference is saved, so it can be restored once the user closes and reopens Zeal. This preference is tipically only accessible through the menubar, so don't add an entry for it in the "Preferences" window.
trollixx
force-pushed
the
add-hide-menubar
branch
from
07bdc91 to
6a8dd76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a "View" submenu to the menubar, that allows the user hide the menubar. I also added a keyboard shortcut (
Ctrl + M, as suggested in issue #1251) to toggle the visibility of the menubar. This preference is saved, so it can be restored once the user closes and reopens Zeal.This preference is tipically only accessible in the "View" submenu, so I didn't add an entry for it in the "Preferences" window. I could do that as well, if you prefer.
I haven't been able to show/hide the menubar when
Altis pressed/released though, so this isn't ready. I decided to create this draft PR anyways, in case someone else knows how to that, since it would solve issue #1251 and make progress towards solving issue #1202.Kooha-2022-11-14-17-25-20.mp4