Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest available @vue/language-server package #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

April-Gras
Copy link

@April-Gras April-Gras commented Oct 21, 2024

Copied from:
zed-industries/zed#18807 (comment):

This PR relates to #9846 which pinned the @vue/language-server package to a version approximately 12 months old. This PR brings behaviour inline with how other JS language extensions works by pulling the latest available package.

I have tested on Zed 0.155.2 and it now seems to be behaving.

Release Notes:

  • N/A

Originaly Authored by @rowanwins

@reslear
Copy link

reslear commented Oct 21, 2024

By the way, can someone put it in beta to check it out?

@April-Gras
Copy link
Author

Is there anything additional required for this PR to move forward ?
I wouldn't mind addressing any potential issues if I'm given directions
Hope I can help

@reslear
Copy link

reslear commented Nov 5, 2024

@April-Gras maybe do friendly ping developers?

@maxdeviant
Copy link
Contributor

My comments from the original PR still haven't been addressed:

Last I checked, there were changes in v2 of the Vue language server that broke certain aspects of the functionality:

The Vue bits of the language server work, but the TypeScript stuff doesn't. And they have a separate language server plugin you can use to add Vue support to tsserver, but then they also put out another release after v2 that added back the old built-in TypeScript support.

It's possible that they have remedied this since last I looked, but we'll need to do due diligence to make sure all of the workloads are still working as expected.

We need to do thorough testing of this, particularly with TypeScript, and make sure that it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants