Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COBOL extension #1812

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Add COBOL extension #1812

merged 1 commit into from
Dec 27, 2024

Conversation

willswire
Copy link
Contributor

@willswire willswire commented Dec 17, 2024

This PR adds initial tree-sitter support for COBOL

@cla-bot cla-bot bot added the cla-signed label Dec 17, 2024
@notpeter

This comment was marked as resolved.

@willswire

This comment was marked as resolved.

@notpeter
Copy link
Member

Does this extension work for you?
When I attempt to run "Install Dev Extension" your repo it does not succeed.

2024-12-18T09:54:55.874369-05:00 [INFO] compiling grammar cobol for extension /Users/peter/source/zed-cobol
2024-12-18T09:54:55.874766-05:00 [INFO] checking out cobol parser
2024-12-18T09:54:55.915161-05:00 [INFO] building git repository, `.git` path in the worktree: "/Users/peter/source/zed-cobol/grammars/cobol/.git"
2024-12-18T09:54:56.177123-05:00 [INFO] building git repository, `.git` path in the worktree: "/Users/peter/source/zed-cobol/grammars/cobol/.git"
2024-12-18T09:54:56.277534-05:00 [INFO] building git repository, `.git` path in the worktree: "/Users/peter/source/zed-cobol/grammars/cobol/.git"
2024-12-18T09:54:57.26128-05:00 [INFO] building git repository, `.git` path in the worktree: "/Users/peter/source/zed-cobol/grammars/cobol/.git"
2024-12-18T09:54:57.362466-05:00 [INFO] building git repository, `.git` path in the worktree: "/Users/peter/source/zed-cobol/grammars/cobol/.git"
2024-12-18T09:54:57.393137-05:00 [INFO] compiling cobol parser
2024-12-18T09:54:57.462856-05:00 [INFO] building git repository, `.git` path in the worktree: "/Users/peter/source/zed-cobol/grammars/cobol/.git"

But it never finishes.

I haven't dug into it further, but wanted to confirm: did you actually test this?

@willswire
Copy link
Contributor Author

Hey, thanks for your patience! I revisited this and made a few adjustments to address the issue you encountered. It’s now building and installing successfully on my end.

Let me know if you run into any more problems, and I’ll be happy to dig in further!

@willswire willswire force-pushed the main branch 2 times, most recently from d3d69e1 to 53b6002 Compare December 21, 2024 01:51
@notpeter notpeter merged commit 3ce6441 into zed-industries:main Dec 27, 2024
3 checks passed
@notpeter
Copy link
Member

Thanks! And congratulations on you first Zed Extension!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cobol
2 participants