Skip to content

Commit

Permalink
editor: Move hunk controls to the right (#19515)
Browse files Browse the repository at this point in the history
This PR moves the hunk controls over to the right so we can see how they
feel over there.

Git:

<img width="1068" alt="Screenshot 2024-10-21 at 10 27 34 AM"
src="https://github.com/user-attachments/assets/71556e22-024a-4bdf-8a99-fe28430b9155">

Live diffs:

<img width="1060" alt="Screenshot 2024-10-21 at 10 27 28 AM"
src="https://github.com/user-attachments/assets/681ff409-dc55-4b63-87d7-7e39016417d2">


Release Notes:

- Moved hunk controls to the right of the header.
  • Loading branch information
maxdeviant authored Oct 21, 2024
1 parent 74e25c1 commit 755fd69
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/editor/src/hunk_diff.rs
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ impl Editor {
h_flex()
.px_6()
.size_full()
.justify_between()
.justify_end()
.child(
h_flex()
.gap_1()
Expand Down

1 comment on commit 755fd69

@thataboy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I typically access the hunk controls by clicking on the hunk bar in the gutter, having the hunk controls on the left means less mouse movement. But I understand putting it on the right to be more consistent with other controls being on the right

Please sign in to comment.