Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blade: Bump rev to fix GLES #13114

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

lukaslihotzki
Copy link
Contributor

@lukaslihotzki lukaslihotzki commented Jun 16, 2024

Based on the work on GLES support of @kvark, only two pieces were missing for usable GLES support:

If you don't want to switch back to mainline blade, please integrate kvark/blade#126 to your fork.

Release Notes:

Copy link

cla-bot bot commented Jun 16, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @lukaslihotzki on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@lukaslihotzki
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jun 16, 2024
Copy link

cla-bot bot commented Jun 16, 2024

The cla-bot has been summoned, and re-checked this pull request!

@mikayla-maki mikayla-maki changed the title blade: bump rev to fix GLES blade: Bump rev to fix GLES Jun 16, 2024
@xgfone
Copy link

xgfone commented Jun 17, 2024

kvark/blade@845cdad has fixed #11192.

And if updating blade to kvark/blade@21a56f7, bugs should also has been fixed.

Copy link
Contributor

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@someone13574 someone13574 mentioned this pull request Jun 20, 2024
1 task
@mikayla-maki mikayla-maki merged commit d5b0df6 into zed-industries:main Jun 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants