Add postcss support, and support vue & svelte <style lang="..."> injections, and highlight svelte block keywords
#18052
Conversation
cla-bot
bot
added
the
cla-signed
| @@ -1,6 +1,6 @@ | |||
| name = "CSS" | |||
| grammar = "css" | |||
| path_suffixes = ["css"] | |||
| path_suffixes = ["css", "postcss"] | |||
There was a problem hiding this comment.
Do people actually use .postcss as a file extension?
I've only ever seen it used with .css.
There was a problem hiding this comment.
If we're just adding this to recognize <style lang="postcss"> I think that would be better handled in the injections query itself.
There was a problem hiding this comment.
Yeah it is in various other plugins
https://marketplace.visualstudio.com/items?itemName=csstools.postcss
It might even be worth adding pcss but up to you.
My argument in favor is that whilst it is compatible with CSS, tonnes of tooling expects the existence of postcss files, or postcss as a preprocessor directive (which users must use in order to trigger the correct preprocessor in their tooling (ie, svelte, vue).
Therefore it is reasonable to add it as a path stuffix
This comment was marked as spam.
This comment was marked as spam.
|
@maxdeviant sorry if that was spam, but I'm just trying to get this merged as there is still an outstanding issue that a user was having due to this - and I think the PR is ready to merge |
|
Splitting this PR into more focused ones: |
This PR adjusts the highlights for `{#each ...}` and `{#if ...}`
expression blocks to use keyword highlighting.
Extracted from #18052.
Release Notes:
- N/A
Co-authored-by: Albert Marashi <[email protected]>
This PR adds support for injecting languages into `<style>` tags using `<style lang="...">` in Vue. Extracted from #18052. Release Notes: - N/A Co-authored-by: Albert Marashi <[email protected]>
This PR adjusts the highlights for `{#each ...}` and `{#if ...}`
expression blocks to use keyword highlighting.
Extracted from zed-industries/zed#18052.
Release Notes:
- N/A
Co-authored-by: Albert Marashi <[email protected]>
…ed#19419) This PR adds support for injecting languages into `<style>` tags using `<style lang="...">` in Vue. Extracted from zed-industries/zed#18052. Release Notes: - N/A Co-authored-by: Albert Marashi <[email protected]>
This PR adjusts the highlights for `{#each ...}` and `{#if ...}`
expression blocks to use keyword highlighting.
Extracted from #18052.
Release Notes:
- N/A
Co-authored-by: Albert Marashi <[email protected]>
This PR adds support for injecting languages into `<style>` tags using `<style lang="...">` in Vue. Extracted from #18052. Release Notes: - N/A Co-authored-by: Albert Marashi <[email protected]>
|
Thanks @maxdeviant |
This PR adjusts the highlights for `{#each ...}` and `{#if ...}`
expression blocks to use keyword highlighting.
Extracted from zed-industries#18052.
Release Notes:
- N/A
Co-authored-by: Albert Marashi <[email protected]>
…ies#19419) This PR adds support for injecting languages into `<style>` tags using `<style lang="...">` in Vue. Extracted from zed-industries#18052. Release Notes: - N/A Co-authored-by: Albert Marashi <[email protected]>
lang="postcss"#18033Release Notes:
postcssas a valid extension in thecsslanguage<style lang="postcss">language support{#each ...}{#if ...}expression blocks keyword highlighting<style lang="...">language injections are now supported