ci: Improve GitHub Action modularity #18861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
maxdeviant
changed the title
notpeter
changed the title
notpeter
changed the title
1 task
mikayla-maki
pushed a commit
that referenced
this pull request
Oct 18, 2024
- Closes: #19351 - Switch to using the official [typos GitHub Action](https://github.com/crate-ci/typos/blob/master/docs/github-action.md) - Move the typos check into `actions/check_style` - Move Squawk Postgres migration check out of `actions/check_style` file into ci.yml - `actions/check_style` can now be run on stateless/linux runners (previous required self-hosted MacOS runner) - ci.yml: Split old `style` into checks into those that can run statelessly (linux) and everything else into a new `migration` group which benefit from the full git checkout available on the MacOS runners. - ci.yml: Move `Check unused dependencies` from style to `linux_tests` - Add `if: github.repository_owner == 'zed-industries'` to all jobs so they won't try and run on GitHub forks.
noaccOS
pushed a commit
to noaccOS/zed
that referenced
this pull request
Oct 19, 2024
- Closes: zed-industries#19351 - Switch to using the official [typos GitHub Action](https://github.com/crate-ci/typos/blob/master/docs/github-action.md) - Move the typos check into `actions/check_style` - Move Squawk Postgres migration check out of `actions/check_style` file into ci.yml - `actions/check_style` can now be run on stateless/linux runners (previous required self-hosted MacOS runner) - ci.yml: Split old `style` into checks into those that can run statelessly (linux) and everything else into a new `migration` group which benefit from the full git checkout available on the MacOS runners. - ci.yml: Move `Check unused dependencies` from style to `linux_tests` - Add `if: github.repository_owner == 'zed-industries'` to all jobs so they won't try and run on GitHub forks.
osiewicz
pushed a commit
that referenced
this pull request
Oct 22, 2024
- Closes: #19351 - Switch to using the official [typos GitHub Action](https://github.com/crate-ci/typos/blob/master/docs/github-action.md) - Move the typos check into `actions/check_style` - Move Squawk Postgres migration check out of `actions/check_style` file into ci.yml - `actions/check_style` can now be run on stateless/linux runners (previous required self-hosted MacOS runner) - ci.yml: Split old `style` into checks into those that can run statelessly (linux) and everything else into a new `migration` group which benefit from the full git checkout available on the MacOS runners. - ci.yml: Move `Check unused dependencies` from style to `linux_tests` - Add `if: github.repository_owner == 'zed-industries'` to all jobs so they won't try and run on GitHub forks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions/check_styleactions/check_stylefile into ci.ymlactions/check_stylecan now be run on stateless/linux runners (previous required self-hosted MacOS runner)styleinto checks into those that can run statelessly (linux) and everything else into a newmigrationgroup which benefit from the full git checkout available on the MacOS runners.Check unused dependenciesfrom style tolinux_testsif: github.repository_owner == 'zed-industries'to all jobs so they won't try and run on GitHub forks.Release Notes: