Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remote jupyter server connection #19257

Closed
wants to merge 10 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 25 additions & 3 deletions crates/quick_action_bar/src/repl_menu.rs
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
use std::time::Duration;

use gpui::{percentage, Animation, AnimationExt, AnyElement, Transformation, View};
use gpui::{percentage, prelude::*, Animation, AnimationExt, AnyElement, Transformation, View};
use repl::{
ExecutionState, JupyterSettings, Kernel, KernelSpecification, KernelStatus, Session,
SessionSupport,
};
use ui::{
prelude::*, ButtonLike, ContextMenu, IconWithIndicator, Indicator, IntoElement, PopoverMenu,
Tooltip,
prelude::*, ButtonLike, ContextMenu, IconWithIndicator, Indicator, IntoElement, Label,
PopoverMenu, Tooltip,
};

use gpui::ElementId;
Expand Down Expand Up @@ -378,3 +378,25 @@ fn session_state(session: View<Session>, cx: &WindowContext) -> ReplMenuState {
},
}
}

// pub fn render_jupyter_url_input(cx: &mut WindowContext) -> AnyElement {
// let input_id = "jupyter-url-input".to_string();
// let label = Label::new("Enter the URL of the running Jupyter Server");
// let text_input = TextInput::new(input_id.clone())
// .placeholder("Enter the url of the running Jupyter Server")
// .on_submit(|value, cx| {
// // Handle the submitted URL here
// println!("Submitted URL: {}", value);
// });

// let submit_button = Button::new("Submit", move |_, cx| {
// let value = cx.get_text_input_value(&input_id);
// println!("Submitted URL: {}", value);
// });

// div()
// .child(label)
// .child(text_input)
// .child(submit_button)
// .into_any_element()
// }
1 change: 1 addition & 0 deletions crates/repl/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ image.workspace = true
language.workspace = true
log.workspace = true
markdown_preview.workspace = true
menu.workspace = true
multi_buffer.workspace = true
project.workspace = true
runtimelib.workspace = true
Expand Down
Loading
Loading