keymaps: Fix how single line editor handles new lines in BufferSearch

[narqo]

This PR updates the JetBrains keymaps preset to handle the shift-enter combination as the SelectPrevMatch action.

That is, it seems that, with the current defaults, pressing the Shift+Enter inside the search editor (single_line mode Editor inside the BufferSearchBar) triggers the "Editor::newline". With the updated defaults, it works as I expect it.

Also, the PR adds the alt-enter in the context of the editor inside the BufferSearchBar to trigger the newline. This matches with how it works in other editors on macOS, e.g. in Xcode.

Release Notes:

• N/A

[notpeter]

Hi @narqo,

These changes are not correct:

zed/assets/keymaps/default-macos.json

Lines 234 to 240 in 709581b

	{
	"context": "BufferSearchBar > Editor",
	"bindings": {
	"alt-enter": "editor::Newline",
	"shift-enter": "search::SelectPrevMatch"
	}
	},

1. Your changes break the existing alt-enter mapping in the BufferSearchBar context: (multi-select all matches)
   

   zed/assets/keymaps/default-macos.json

   Line 228 in f6fad3b

   "alt-enter": "search::SelectAllMatches",

2. Were we to add it to this context, the key would be ctrl-enter (like vscode) not alt-enter (like XCode), but we'd likely want fix this before shipping a new default keybinding:

• Find/replace UI should support newlines #15046

3. The thing you are trying to fix, shift-enter being broken -- is only broken in vim mode. It already works fine by default in non-vim mode.

[narqo]

@notpeter, you're right, my bad. I missed that part that I'm using JetBrains preset, where the shift-enter combination is used for the new line, and clashes with search::SelectPrevMatch. I've updated the PR (and the description), moving the fix to the corresponding [jetbrains] preset. PTAL.

[notpeter]

I was able to actually reproduce this with the default vscode keymap + vim mode and so I think the underlying issue might be one with Vim mode contexts. That is, shift-enter correctly works in this context when vim mode is off, but is broken when vim mode is on:

zed/assets/keymaps/default-macos.json

Lines 222 to 227 in 9d61cd5

	"context": "BufferSearchBar",
	"bindings": {
	"escape": "buffer_search::Dismiss",
	"tab": "buffer_search::FocusEditor",
	"enter": "search::SelectNextMatch",
	"shift-enter": "search::SelectPrevMatch",

It's probably worth filing an issue as changing the keymap is not likely the correct solution.

[narqo]

I think the underlying issue might be one with Vim mode contexts

I don't use Vim mode, but I use the JetBrains base keymap. Sorry for the confusion. You can look up my full set of Zed settings in this gist, if that helps.

[notpeter]

Thanks!