ci: Check spelling separately from formatting #19385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
|
PR to fix this upstream. crate-ci/typos#1125 |
mikayla-maki
pushed a commit
that referenced
this pull request
Oct 18, 2024
This PR moves the spelling check out of the `check_style` action, which we can leave for just checking formatting. We can't use the `crates-ci-typos` action as-is on the macOS runners due to the absence of `wget`. Release Notes: - N/A
noaccOS
pushed a commit
to noaccOS/zed
that referenced
this pull request
Oct 19, 2024
This PR moves the spelling check out of the `check_style` action, which we can leave for just checking formatting. We can't use the `crates-ci-typos` action as-is on the macOS runners due to the absence of `wget`. Release Notes: - N/A
osiewicz
pushed a commit
that referenced
this pull request
Oct 22, 2024
This PR moves the spelling check out of the `check_style` action, which we can leave for just checking formatting. We can't use the `crates-ci-typos` action as-is on the macOS runners due to the absence of `wget`. Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the spelling check out of the
check_styleaction, which we can leave for just checking formatting.We can't use the
crates-ci-typosaction as-is on the macOS runners due to the absence ofwget.Release Notes: