Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: More Java extension documentation #19390

Merged
merged 2 commits into from
Oct 18, 2024
Merged

docs: More Java extension documentation #19390

merged 2 commits into from
Oct 18, 2024

Conversation

notpeter
Copy link
Member

@notpeter notpeter commented Oct 17, 2024

Follow up of: #19113

cc: @valentinegb @ABckh @HeavySnowJakarta

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 17, 2024
@maxdeviant maxdeviant changed the title docs: More java extension documentation docs: More Java extension documentation Oct 17, 2024
@notpeter notpeter merged commit 5168fc2 into main Oct 18, 2024
3 checks passed
@notpeter notpeter deleted the docs_more_java branch October 18, 2024 00:21
Copy link
Contributor

@valentinegb valentinegb Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong line! Initialize Request section of the Eclipse.jdt.ls Wiki is what we want, JDTLS Language Server Settings & Capabilities is what we don’t want.
(Edit: this comment was meant to be on specifically a5d5edb, sorry.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL. Put up a PR and I'll merge it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, you'll have to give me a few minutes though since I just got home, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants