Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client::zed_urls module for constructing zed.dev URLs #19391

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

maxdeviant
Copy link
Member

This PR adds a new zed_urls module to the client crate.

This module contains functions for constructing URLs to Zed properties, such as zed.dev.

The URLs produced by this module will respect the server URL set via settings or the ZED_SERVER_URL environment variable. This allows them to correctly reflect the current environment (such as when testing Zed against a local collab/zed.dev).

Release Notes:

  • N/A

@maxdeviant maxdeviant self-assigned this Oct 17, 2024
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 17, 2024
@maxdeviant maxdeviant merged commit 2bcf9fc into main Oct 17, 2024
11 checks passed
@maxdeviant maxdeviant deleted the marshall/add-functions-for-constructing-zed-urls branch October 17, 2024 20:18
mikayla-maki pushed a commit that referenced this pull request Oct 18, 2024
This PR adds a new `zed_urls` module to the `client` crate.

This module contains functions for constructing URLs to Zed properties,
such as zed.dev.

The URLs produced by this module will respect the server URL set via
settings or the `ZED_SERVER_URL` environment variable. This allows them
to correctly reflect the current environment (such as when testing Zed
against a local collab/zed.dev).

Release Notes:

- N/A
noaccOS pushed a commit to noaccOS/zed that referenced this pull request Oct 19, 2024
…stries#19391)

This PR adds a new `zed_urls` module to the `client` crate.

This module contains functions for constructing URLs to Zed properties,
such as zed.dev.

The URLs produced by this module will respect the server URL set via
settings or the `ZED_SERVER_URL` environment variable. This allows them
to correctly reflect the current environment (such as when testing Zed
against a local collab/zed.dev).

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant