Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update info on JDTLS install for Java #19436

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

valentinegb
Copy link
Contributor

@notpeter @ABckh @HeavySnowJakarta really sorry to open yet another PR for the Java docs, but the Zed Java extension now auto-downloads JDTLS (surprise!) so the information related to that in the docs is no longer accurate.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 18, 2024
@ABckh
Copy link
Contributor

ABckh commented Oct 18, 2024

These are similar in that this PR uses the Eclipse JDT Language Server which zed-java-eclipse-jdtls also uses. They are different in I'm sure many small ways (simply differing implementations of completion labels for instance) but most notably @ABckh maintains a repository to allow for zed-java-eclipse-jdtls to download JDTLS for you, while this PR would have zed-extensions/java ask you to install JDTLS yourself (it's available on Homebrew). Also, this PR adds a setting to let you change the Java binary that JDTLS will use (for different versions of Java, for example).

Hi @valentinegb! What is the difference between the extensions now then?
I am just really curious that we do the same stuff twice, the history was:

  1. There was zed-java-eclipse-jdtls which used jdtls
  2. Then you added jdtls to zed -java and pointed that the main difference to keep both is that one of them do not install jdtls automatically
  3. You added auto installation of jdtls to zed-java

Now after you have added the same stuff to zed-java it becomes the same as zed-java-eclipse-jdtls. I am just a bit disappointed with how things work done with java extensions

@notpeter notpeter merged commit be474a6 into zed-industries:main Oct 18, 2024
3 checks passed
@notpeter
Copy link
Member

Thanks for this. I moved the section on manually installing to the bottom and consolidated the examples a bit. Feel free to keep additions/changes coming. We've adjusted the CI so docs-only PRs only take 15seconds to re-test so it's easier to make small incremental improvements.

@valentinegb
Copy link
Contributor Author

@ABckh, I do apologize that there's now only really nuanced differences between the extensions, but the nuances do exist, and I hope that you can consider this just some friendly competition ^^

And @notpeter, thanks for your help through all this!

@valentinegb valentinegb deleted the docs-java-jdtls-install branch October 18, 2024 21:26
@ABckh
Copy link
Contributor

ABckh commented Oct 18, 2024

@ABckh, I do apologize that there's now only really nuanced differences between the extensions, but the nuances do exist, and I hope that you can consider this just some friendly competition ^^

And @notpeter, thanks for your help through all this!

No need to apologize. This is why I’m disappointed—it doesn’t feel like fair competition. zed-java gained popularity early on, despite not working well, likely due to historical reasons. Then we built something that works, and it started gaining traction (8k downloads so far). However, all of our features were copied into the original extension. People will likely install the original extension since it has more downloads and now the same features. They don’t care about competition, and zed-java-eclipse-jdtls won’t get the attention it deserves.

The real issue is that I’ve lost motivation to work on new features. If I add something new, it will just get copied into the zed-java extension anyway. Maybe this isn’t just a problem with how Zed manages extensions, but a broader issue with open source in general. 🙂

@valentinegb
Copy link
Contributor Author

@ABckh I get what you mean... I honestly would really like if we would both work on zed-java instead of maintaining separate extensions, that way, with your help, we can have a Java extension that's as good as can be, while also making sure all the features are taken advantage of by all Zed Java devs. That was my goal when I started contributing to zed-java, and I mostly achieved that, but it's maybe not "as good as can be" yet and there's still a split between what extension Java devs use, although both extensions are pretty good, so the split isn't quite as important now. You expressed before that you wanted to keep working on zed-java-eclipse-jdtls, so I had decided that I wasn't going to try to convince you to work on zed-java instead.

So, it is a bit unfair, and that's not how I meant for it to be, but that is how it ended up. I don't make decisions for you of course, but I do think it's in both of our best interests if you worked on zed-java instead of zed-java-eclipse-jdtls, although I will do my best to respect whatever decision you make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants