Fix flakey SSH connection #19439
Merged
Fix flakey SSH connection #19439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
co-authored-by: mikayla <[email protected]>
mikayla-maki
force-pushed
the
fix-select-stuff
branch
from
9c5ff95
to
866b233
Compare
co-authored-by: conrad <[email protected]>
mikayla-maki
force-pushed
the
fix-select-stuff
branch
from
d733b5a
to
6a1ace1
Compare
mikayla-maki
force-pushed
the
fix-select-stuff
branch
from
54f390a
to
4362e52
Compare
|
whoa! |
noaccOS
pushed a commit
to noaccOS/zed
that referenced
this pull request
Oct 19, 2024
Fixes a bug due to the `select!` macro tossing futures that had partially read messages, causing us to desync our message reading with the input stream. Release Notes: - N/A --------- Co-authored-by: Conrad Irwin <[email protected]> Co-authored-by: conrad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug due to the
select!macro tossing futures that had partially read messages, causing us to desync our message reading with the input stream.Release Notes: