-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve editor tabs and project panel items #20134
Open
nervenes
wants to merge
14
commits into
zed-industries:main
Choose a base branch
from
nervenes:tabs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+316
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
The user has signed the Contributor License Agreement
label
Nov 3, 2024
nervenes
changed the title
[WIP] Improve pane items and project panel items.
[WIP] Improve pane items and project panel items
Nov 3, 2024
nervenes
changed the title
[WIP] Improve pane items and project panel items
[WIP] Improve workspace pane items and project panel items
Nov 3, 2024
nervenes
changed the title
[WIP] Improve workspace pane items and project panel items
Improve workspace pane items and project panel items
Nov 3, 2024
i recommend running the branch locally to see how things have changed |
Before I dive in too deep: have you seen the discussion in #18182 on icons in the project panel? |
Yep, i left a comment: #18182 (comment) |
nervenes
changed the title
Improve workspace pane items and project panel items
Improve editor tabs and project panel items
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #16615 and #16671
Notes
previously, the
git_status
option in bothproject_panel
andtabs
settings was used to toggle git coloring, this option name is a bit misleading now with git symbols in place which are the actual statuses, so i've changedgit_status
to toggle the git symbols on and off instead (to avoid a breaking change). for git coloring, i've added a new option calledgit_colors
that can be toggled.git_status
andgit_colors
default totrue
in bothproject_panel
andtabs
.file_icons
intabs
to true for a more consistent relation with theproject_panel
.Screenshot
Release Notes:
git_status
option now refers to git symbols, with an addedgit_colors
option for coloring, both are set totrue
by default. (#20134)file_icons
intabs
to default totrue
. (#20134)