Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve editor tabs and project panel items #20134

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

nervenes
Copy link
Contributor

@nervenes nervenes commented Nov 3, 2024

Continuation of #16615 and #16671

Notes

previously, the git_status option in both project_panel and tabs settings was used to toggle git coloring, this option name is a bit misleading now with git symbols in place which are the actual statuses, so i've changed git_status to toggle the git symbols on and off instead (to avoid a breaking change). for git coloring, i've added a new option called git_colors that can be toggled.

  • both git_status and git_colors default to true in both project_panel and tabs.
  • i've also defaulted file_icons in tabs to true for a more consistent relation with the project_panel.

Screenshot

Skärmavbild 2024-11-04 kl  19 23 43

Release Notes:

  • Added git symbols to the project panel and editor tabs, the git_status option now refers to git symbols, with an added git_colors option for coloring, both are set to true by default. (#20134)
  • Added symlink symbol to editor tabs. (#20134)
  • Disable the dirty buffer indicators in tabs when autosave is enabled. (#20134)
  • Improved the editor tabs layout. (#20134)
  • Changed file_icons in tabs to default to true. (#20134)

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 3, 2024
@nervenes nervenes marked this pull request as draft November 3, 2024 13:11
@nervenes nervenes changed the title [WIP] Improve pane items and project panel items. [WIP] Improve pane items and project panel items Nov 3, 2024
@nervenes nervenes changed the title [WIP] Improve pane items and project panel items [WIP] Improve workspace pane items and project panel items Nov 3, 2024
@nervenes nervenes changed the title [WIP] Improve workspace pane items and project panel items Improve workspace pane items and project panel items Nov 3, 2024
@nervenes nervenes marked this pull request as ready for review November 3, 2024 22:22
@nervenes
Copy link
Contributor Author

nervenes commented Nov 3, 2024

cc @mrnugget @iamnbutler

i recommend running the branch locally to see how things have changed

@mrnugget
Copy link
Member

mrnugget commented Nov 4, 2024

Before I dive in too deep: have you seen the discussion in #18182 on icons in the project panel?

@nervenes
Copy link
Contributor Author

nervenes commented Nov 4, 2024

Yep, i left a comment: #18182 (comment)

@nervenes nervenes changed the title Improve workspace pane items and project panel items Improve editor tabs and project panel items Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants