assistant: Fix safety settings for google_ai #20178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors to sign our Contributor License Agreement, and we don't have @FedorBuben on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
maxdeviant
reviewed
Nov 4, 2024
| safety_settings: None, | ||
| safety_settings: Some(vec
There was a problem hiding this comment.
Not blocking any dangerous content seems like the wrong choice for a default.
There was a problem hiding this comment.
Should there be an option for adjusting the filter settings?
HarmCategory::DangerousContent is one of the 5 categories. The filter currently blocks content in all other categories.
From Gemini API Docs:
The Gemini API's adjustable safety filters cover the following categories:
| Category | Description |
|---|---|
| Harassment | Negative or harmful comments targeting identity and/or protected attributes. |
| Hate speech | Content that is rude, disrespectful, or profane. |
| Sexually explicit | Contains references to sexual acts or other lewd content. |
| Dangerous | Promotes, facilitates, or encourages harmful acts. |
| Civic integrity | Election-related queries. |
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes Gemini API's safety filter blocks code, considering it dangerous content. This happens quite often. The bug has been described in some comments under #18561. Here is an example prompt for Gemini Flash.
In Zed:
In Google AI Studio:
Disabling the
DangerousContentcategory for the filter solves the problemRelease Notes: