Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish streaming slash commands #20345

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Polish streaming slash commands #20345

merged 3 commits into from
Nov 7, 2024

Conversation

as-cii
Copy link
Member

@as-cii as-cii commented Nov 7, 2024

This improves the experience in a few ways:

  • It avoids merging slash command output sections that are adjacent.
  • When hitting cmd-z, all the output from a command is undone at once.
  • When deleting a pending command, it stops the command and prevents new output from flowing in.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 7, 2024
@as-cii as-cii merged commit 16cbff9 into main Nov 7, 2024
9 checks passed
@as-cii as-cii deleted the polish-commands branch November 7, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant