Improve multibuffer excerpt affordances #22167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Co-Authored-By: Thorsten Ball <[email protected]>
Co-Authored-By: Thorsten Ball <[email protected]>
Co-Authored-By: Agus Zubiaga <[email protected]>
co-authored-by: Agus Zubiaga <[email protected]>
co-authored-by: Agus Zubiaga <[email protected]>
SomeoneToIgnore
force-pushed
the
multibuffer-excerpt-interaction-improvement
branch
from
7e89b67 to
1a331ff
Compare
Co-Authored-By: Agus Zubiaga <[email protected]>
Co-Authored-By: Danilo <[email protected]>
…e-based-focus Display "Jump to File" display based on focus
Co-Authored-By: Danilo <[email protected]>
Co-Authored-By: Danilo <[email protected]>
Co-Authored-By: Danilo <[email protected]>
🫶 |
helgemahrt
pushed a commit
to helgemahrt/zed
that referenced
this pull request
Jan 1, 2025
Changes: - [x] Increase expand affordance surface area - [x] Ensure expand buttons have tooltips with keybindings - [x] Make line numbers clickable to jump you to location (only in multibuffers) - [x] Hide the "Jump To File" element in not-focused excerpts Before merging it: - [x] Fix off-by-one header focus styles glitch Improvements to consider for follow-up PRs: 1. Experiment with increasing the width of the clickable surface area for line numbers 2. Don't show (or disable) the "expand excerpt" button when at the top or bottom edge of the file 3. Once you jump to location, centralize the cursor scroll position Release Notes: - Improved multibuffer's "expand excerpt" affordance - Fixed "jump to file/location" and "expand excerpt" keybinding display - Made clicking on line numbers in multibuffers jump you to cursor location in file --------- Co-authored-by: Thorsten Ball <[email protected]> Co-authored-by: Agus Zubiaga <[email protected]> Co-authored-by: Kirill Bulatov <[email protected]> Co-authored-by: Agus Zubiaga <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Improvements to consider for follow-up PRs:
Release Notes: