elm: Improve syntax highlighting and bracket handling #22293
Closed
+196
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
maxdeviant
changed the title
|
I also changed the default tab_size to 4 as that's how most of Elm projects are formatted. elm-format uses 4 spaces and it's not configurable. |
|
@edkv The elm support has been moved to https://github.com/zed-extensions/elm. That said, these changes seem reasonable to me, so a PR there would be a good idea! cc @maxdeviant |
|
@ConradIrwin Okay, created a PR in the new repo. |
maxbrunsfeld
pushed a commit
to zed-extensions/elm
that referenced
this pull request
Jan 10, 2025
Moved from zed-industries/zed#22293. - Fixes various issues with current syntax highlighting: modules and patterns are not highlighted, number literals are treated as constants etc. New highlights are mostly copied from [nvim-treesitter](https://github.com/nvim-treesitter/nvim-treesitter/blob/master/queries/elm/highlights.scm) with some modifications and removals of things that are not supported by Zed. In particular, `@modules` are highlighted as `@title`, similarly to how it's done in Zed's Haskell extension. - Added `brackets.scm`. - Changed the default tab_size to 4 as that's how most of Elm projects are formatted and what elm-format uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various issues with current syntax highlighting for Elm: modules and patterns are not highlighted, number literals are treated as constants etc.
New highlights are mostly copied from nvim-treesitter with some modifications and removals of things that are not supported by Zed. In particular,
@modules are highlighted as@title, similarly to how it's done in Zed's Haskell extension.Also added
brackets.scm.