Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update suggest_edits prompt to clarify usage of <old_text> when using update/create operations #22341

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

mattprodani
Copy link
Contributor

@mattprodani mattprodani commented Dec 21, 2024

Update suggest_edits prompt to clarify usage of <old_text> when using update/create operations using update/create operations.

  • Add a mention that old_text is required for all but create.
  • Change definition of create operation to also mean overwrite, as some models heavily prefer rewrites.
  • Remove mention of If this tag is not specified, then the entire file will be used as the range. which is not current behavior.

Closes #22340

Release Notes:

  • N/A (not sure if this requires a release note)

Copy link

cla-bot bot commented Dec 21, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @mattprodani on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@mattprodani
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 21, 2024
Copy link

cla-bot bot commented Dec 21, 2024

The cla-bot has been summoned, and re-checked this pull request!

…sing update/create operations.

- Add a mention that `old_text` is required for all but create
- Change definition of `create` operation to also mean overwrite, as
  some models heavily prefer rewrites.
- Remove mention of entire range being used as `old_text` when not
  specified.
@mattprodani mattprodani changed the title Update suggest_edits prompt to clarify usage of <old_text> when using update/create operations using update/create operations. Update suggest_edits prompt to clarify usage of <old_text> when using update/create operations Dec 21, 2024
@mgsloan
Copy link
Contributor

mgsloan commented Jan 8, 2025

I've taken a look at the implementation of the create operation, and those changes make sense to me, thanks!

@mgsloan mgsloan enabled auto-merge January 8, 2025 23:27
@mgsloan mgsloan added this pull request to the merge queue Jan 8, 2025
Merged via the queue into zed-industries:main with commit a9d2628 Jan 9, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify <old_text> requirement and difference between create/update in suggest_edits prompt.
2 participants