Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assistant2: Add icons to the context pill #22385

Merged

Conversation

danilo-leal
Copy link
Contributor

This PR adds an icon field to the ContextKind enum, which means that icons will now display on context pills, both on the message editor and on the active thread.

Screenshot 2024-12-24 at 12 23 17 AM

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 24, 2024
@danilo-leal danilo-leal added this pull request to the merge queue Dec 24, 2024
Merged via the queue into zed-industries:main with commit 3d4e078 Dec 24, 2024
13 checks passed
@danilo-leal danilo-leal deleted the assistant2-add-icon-context-pill branch December 24, 2024 04:30
github-merge-queue bot pushed a commit that referenced this pull request Dec 24, 2024
…ng (#22397)

This PR is a follow up to #22385 that makes it so we treat the icon as
derived state.

Release Notes:

- N/A
helgemahrt pushed a commit to helgemahrt/zed that referenced this pull request Jan 1, 2025
This PR adds an icon field to the `ContextKind` enum, which means that
icons will now display on context pills, both on the message editor and
on the active thread.

<img width="800" alt="Screenshot 2024-12-24 at 12 23 17 AM"
src="https://github.com/user-attachments/assets/f00e540b-30fe-49ac-b3df-7c7a5dc86d65"
/>

Release Notes:

- N/A
helgemahrt pushed a commit to helgemahrt/zed that referenced this pull request Jan 1, 2025
…ng (zed-industries#22397)

This PR is a follow up to zed-industries#22385 that makes it so we treat the icon as
derived state.

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant