Prevent propagating mouse events and use button elements instead of plain text in the update notification #23665
+15
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… elements underneath the notification, use `Button` and `IconButton` elements for release notes and close buttons
cla-bot
bot
added
the
cla-signed
maxdeviant
changed the title
update_notification: prevent propagating mouse events and use button elements instead of plain text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having project panel on the right,
update_notificationwould let mouse events propagate to it, causing hover effect and opening files. I also usedButtonandIconButtonfor clickable elements inside of the notification in order to be consistent with the rest of UI.Before:
Screencast.from.2025-01-26.00-31-26.mp4
After:
Screencast.from.2025-01-26.00-29-01.mp4
One thing I haven't been able to fix is pane resize event triggering (seen in both screencasts), so any help there is more than welcome.