Catch empty error condition

(rare, but could occur if connection to Square times out)
zencart · Jun 21, 2020 · 19df191 · 19df191
1 parent 0eae6f5
commit 19df191
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/files_to_upload/includes/modules/payment/square.php b/files_to_upload/includes/modules/payment/square.php
@@ -1264,13 +1264,15 @@ protected function parse_error_response($error_object)
         $msg = '';
         $first_category = null;
         $first_code = null;
-        foreach ($error_object as $err) {
-            $category = method_exists($err, 'getCategory') ? $err->getCategory() : $err->category;
-            $code = method_exists($err, 'getCode') ? $err->getCode() : $err->code;
-            $detail = method_exists($err, 'getDetail') ? $err->getDetail() : $err->detail;
-            $msg .= "$code: $detail\n";
-            if (is_null($first_category)) $first_category = $category;
-            if (is_null($first_code)) $first_code = $code;
+        if (!empty($error_object)) {
+            foreach ($error_object as $err) {
+                $category = method_exists($err, 'getCategory') ? $err->getCategory() : $err->category;
+                $code = method_exists($err, 'getCode') ? $err->getCode() : $err->code;
+                $detail = method_exists($err, 'getDetail') ? $err->getDetail() : $err->detail;
+                $msg .= "$code: $detail\n";
+                if (is_null($first_category)) $first_category = $category;
+                if (is_null($first_code)) $first_code = $code;
+            }
         }
         $msg = trim($msg, "\n");
         $msg = str_replace("\n", "\n<br>", $msg);
@@ -1279,7 +1281,6 @@ protected function parse_error_response($error_object)
 
         return array('detail' => $msg, 'category' => $first_category, 'code' => $first_code);
     }
-
 }
 
 // helper for Square admin configuration: locations selector