feat: update theme to use theming api v4 #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build request form using data helpers
feat: request form using field data helpers
Ticket Form Selector
Setup improvements
Minimize generated JS bundles
fix: always redirect to the new request page when a ticket form is selected
fix: text reflow a11y issue in the Answer Bot modal
refactor: align with the refactored APIs for the parent request
Merge branch 'master' into v4-alpha
fix: clearing date field when it is hidden
chore: added test id for suggested articles
chore: commit minified assets
docs: added information about the React components
kubraokcu
reviewed
Jul 3, 2024
| @@ -17,6 +25,7 @@ parts: | |||
| title: "Title of the footer of the Answer Bot Modal" | |||
| screenshot: "https://drive.google.com/file/d/14qsEyUiVTy9MRYBGkgVWLmlduhoscYBw/view?usp=drive_link" | |||
| value: "Does this article answer your question?" | |||
| obsolete: "2024-08-22" | |||
There was a problem hiding this comment.
Suggested change
| obsolete: "2024-08-22" | |
| obsolete: "2024-09-22" |
The date should be at least 2 months in the future :)
There was a problem hiding this comment.
Thanks, changed
BREAKING CHANGE: theme is now relying on functionality that is exclusive to the theming api v4
gosiexon-zen
force-pushed
the
mbien/templating-api-v4
branch
from
cf9f605
to
d89b0a5
Compare
kubraokcu
approved these changes
Jul 3, 2024
kubraokcu
added
g11n-approved
Fredx87
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates Copenhagen Theme to use Templating API v4 (docs)
Screenshots
Checklist