fix: support more uncommon file types for attachments #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fredx87
force-pushed
the
gianluca/GG-3798-attachments-fix
branch
from
99d7106
to
9dca6e3
Compare
Fredx87
force-pushed
the
gianluca/GG-3798-attachments-fix
branch
from
9dca6e3
to
97d1fa3
Compare
BrunoBFerreira
approved these changes
Aug 21, 2024
|
🎉 This PR is included in version 4.0.11 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems that the fix implemented in #514 was not enough to solve the issue with attachment uploads of uncommon file types. We decided to not pass the
Content-Typeand let the backend set it, but the backend is still returning a 406 response for some file types (for example for a.pcapfile).The only fix we can implement on our side is to use a library to determine the correct mime type based on the file extension. I used the mime library, which adds ~10K to the
shared-bundle.jsfile when gzipped.Checklist