Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use target endpoints for Service Catalog list and item #544

Open
wants to merge 1 commit into
base: service-catalog-eap
Choose a base branch
from

Conversation

gosiexon-zen
Copy link
Contributor

Description

Removed mock and call to Custom Objects API and instead use target endpoints created for Service Catalog:

/api/v2/help_center/service_catalog/items.json
/api/v2/help_center/service_catalog/items/{id}.json

For EAP we are reading the service item id from the URL as we are passing it by clicking the item on the list and redirecting. to the service item page. For GA we will read it from curlybars.
Added component for description for service item to handle showing the "read more" button when the description is shorter.
Jira issue GG-3951

Screenshots

Checklist

  • 📗 all commit messages follow the conventional commits standard
  • ⬅️ changes are compatible with RTL direction
  • ♿ Changes to the UI are tested for accessibility and compliant with WCAG 2.1.
  • 📝 changes are tested in Chrome, Firefox, Safari and Edge
  • 📱 changes are responsive and tested in mobile
  • 👍 PR is approved by @zendesk/vikings

@gosiexon-zen gosiexon-zen requested a review from a team as a code owner November 15, 2024 11:44
@gosiexon-zen gosiexon-zen force-pushed the mbien/use-target-endpoint-for-sc branch from 3c88d26 to 0136e2f Compare November 15, 2024 11:45
@gosiexon-zen gosiexon-zen changed the title Use target endpoint for Service Catalog Use target endpoints for Service Catalog list and item Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant