Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combobox): handle IME via controlled input #1624

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix(combobox): handle IME via controlled input #1624

merged 1 commit into from
Sep 21, 2023

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Sep 21, 2023

Description

This PR upgrades the combobox container with onChange override logic that corrects the underlying Downshift IME entry bug.

Detail

zendeskgarden/react-containers#588

@jzempel jzempel requested a review from a team as a code owner September 21, 2023 18:19
@coveralls
Copy link

Coverage Status

coverage: 95.483%. remained the same when pulling c571c9d on jzempel/up-combobox into 56ae5b0 on main.

@jzempel jzempel merged commit 6409b9b into main Sep 21, 2023
6 checks passed
@jzempel jzempel deleted the jzempel/up-combobox branch September 21, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smritimadan smritimadan smritimadan approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jzempel @coveralls @smritimadan @zendesk-garden