This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Change ZendViewRenderer to DI only; remove fallback dependency setup #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a narrative description of what you are trying to accomplish:
This PR removes fallback PhpRenderer setup from ZendViewRenderer and moves NamespacedPathStackResolver setup into factory.
ZendViewRenderer requires zend-view renderer and NamespacedPathStackResolver to be explicitly provided at creation time; It won't try to inspect or configure zend-view renderer resolvers and expects them to be configured beforehand.
This greatly simplifies template renderer and forces separation of concern to avoid the need to modify template renderer to configure its dependencies as has been done in add support for custom template file default suffix #64
Extra ZendViewRenderer parameter added in add support for custom template file default suffix #64 is dropped in this PR as that feature is moved into factory.
Users depending on
Zend\Expressive\ZendView\ConfigProvider
to configure their container can continue to use the same provided services without change.Users directly instantiating
Zend\Expressive\ZendView\ZendViewRenderer
will need to update their code to provide zend-view renderer (PhpRenderer by default) and NamespacedPathStackResolver as constructor parameters; zend-view renderer is expected to be already configured with NamespacedPathStackResolver.develop
branch, and submit against that branch.CHANGELOG.md
entry for the new feature.