-
Notifications
You must be signed in to change notification settings - Fork 111
Drop dependency on zendframework/zend-loader #186
base: develop
Are you sure you want to change the base?
Conversation
Builds are failing with latest dependencies, but they are failing in master too. I'll try to figure out how to fix them, but it might take me time. |
Please rebase onto develop |
There is a PR with fix, I will merge it shortly |
Perfect then. Thanks. |
I have rebased develop. I'll do it again once you merge the other PR. |
Just a heads up: there is a big ongoing effort going for next major versions for zend-expressive and related packages as well as for zend-mvc. This change will require a next major version, and I do not expect to get to it until february. |
Ok, no rush :-) |
src/Headers.php
Outdated
* @var \Zend\Loader\PluginClassLoader | ||
*/ | ||
protected $pluginClassLoader = null; | ||
const HEADERS_CLASS_MAP = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not configurable.
Please move this into a variable in separate class with methods get($name)
, has($name)
, add($name, $class)
, remove($name)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize it had to be configurable. I'll fix it right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we move the logic to a class, should it be handled as the HeaderLoader
used to?
Do we want to keep exposing it via public getter?
This repository has been moved to laminas/laminas-mail. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
This repository has been closed and moved to laminas/laminas-mail; a new issue has been opened at laminas/laminas-mail#39. |
This removes the dependency on the zendframework/zend-load package, as suggested in #185
The
HeaderLoader
class has been removed and replaced by a simple class map in theHeaders
class.However, I have also removed the
getPluginClassLoader
andsetPluginClassLoader
methods. Since they are public, this might be a BC break. What do you think?