Fix off by one

zengm-games · Oct 11, 2024 · 8dd5a41 · 8dd5a41
1 parent 51335f1
commit 8dd5a41
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/TODO b/TODO
@@ -7,7 +7,6 @@ Add blown saves (BS) and holds (HLD)
 - confirm exhibition game works
 - show decision in player game log (similar to box score, maybe reuse code form BoxScoreRow.football)
   - sort
-  - off by one, why is box score working correctly then?
   - no decision column for position players
   - blog
 

diff --git a/src/worker/views/playerGameLog.ts b/src/worker/views/playerGameLog.ts
@@ -137,8 +137,11 @@ const updatePlayerGameLog = async (
 					for (const key of extraBaseballStats) {
 						gameStats.seasonStats[key] = p.seasonStats[key];
 						gameStats[key] = p[key];
-						if (gameStats[key] !== undefined) {
+						if (gameStats[key] > 0) {
 							showDecisionColumn = true;
+
+							// seasonStats is from before game, so add to reflect after game
+							gameStats.seasonStats[key] += gameStats[key];
 						}
 					}
 				}