17 new easter eggs #281
17 new easter eggs #281
Conversation
|
I was pretty mixed on whether or not to make them guaranteed to appear. I'm open to either |
src/worker/core/draft/genPlayers.ts
Outdated
| ); | ||
| p.born.year = draftYear - 75; | ||
| p.born.loc = "Roman Empire"; | ||
| p.college = "None"; |
There was a problem hiding this comment.
No college should be "" rather than "None"
| @@ -157,6 +157,669 @@ const genPlayers = async ( | |||
| tids: [g.get("userTid")], | |||
| }); | |||
| } | |||
| }; | |||
| if (Math.random() < 0.75) { | |||
There was a problem hiding this comment.
A lot of this code winds up being repetitive. Would probably be good to put it in a function or loop, like:
const easterEggInfos = [{
firstName: "Augustus",
hgt: 69,
// .. all other parameters that vary here
}];
for (const info of easterEggInfos) {
// all the code that's the same goes here
}
If you're not sure how to do that, no worries :)
|
Very cool! Like I think I told you before, this is something I've wanted to do for a while, but just haven't yet. This does raise a great bikeshedding question, of how you pick the people to include. Like really, thousands of years of civilization and JFK makes it? JFK over all of the BC-era rulers? Yeah BBGM can go into negative years. So why not Ramsses II, Hammurabi, etc? https://ideas.time.com/2013/12/10/whos-biggest-the-100-most-significant-figures-in-history/ turned up in Google and has some other names that I feel might be more appealing than some of your choices, but that could be just because I honestly have no clue who some of your people are :) Also I wonder if you can fit any fun stuff in the ratings themselves. Like for Trump I gave him a 0 passing rating (cause he's selfish) and the "perimeter defense" skill (although I guess that should be reconsidered given the progress on the wall so far). @nicidob just tagging you cause it's relevant to your rosters, and also... do you have any thoughts on this? I feel like you will have some thoughts on this :) |
|
I basically just pulled up a list significant people by century, and just picked out the ones I liked the most and known more than others. I did want to add people like Jesus and Hitler but I'm not sure if the reactions to seeing them would be positive, I was also a bit concerned about adding a lot of mb with images so I didn't add a bunch more well known names. Now for putting the code in a loop.... yeah I'm bad at this :), |
There's a 75% chance each of these players appear in their specific years. The year they appear is usually based on whenever they becoming a king/emperor/president and if they were younger than 19 they're put as 19 yo at draft.
name - year
Augustus - 14
Dong Zhuo - 188 - 19 yo
Philip The Arab - 244
Julian The Apostate - 360
Attila The Hun - 433
King Arthur - 500 - 19 yo
Zhu Wen - 907
Leif Erikson - 989 - 19 yo
Genghis Khan - 1206
Emperor Zhu Yuanzhang - 1370
Joan Of Arc - 1431 - 19 yo
Christopher Columbus - 1492
William Shakespeare - 1573 - 19 yo
King Louis XIV - 1657
George Washington - 1789
Abraham Lincoln - 1861
John Kennedy - 1960
Ratings of old guys are similar to Trump's, Ball's, the young ones are typically around 63 overall at 19 yo.
These guys actually give people a reason to start their leagues in past years with the newer feature that lets random leagues start at any season. Nicidob's new file that starts in 1364 gets a bit more interesting as well.
I feel like not many people will recognize most of the pre-11th century people other than Leif Erikson and King Arthur, but I think they're all cool people! I didn't wanna add any super religious figures, which probably would've been more recognized, but if people dislike the country Israel and the team name Dallas Snipers then I'm not sure if they'd like to see prophet muhammad balling out.