Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the player trading card #447

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ItamarTati
Copy link

I need some help with when it should and shouldn't render, how do I determine who is a legend.

And Also where should the card be

@dumbmatter
Copy link
Member

dumbmatter commented May 18, 2023

Thanks! Looks like a good start, I will probably merge it and mess around with it.

Sorry for not mentioning before, but can you make sure you're okay with the license and sign the CLA? https://github.com/zengm-games/zengm/tree/master#license-and-contributor-license-agreement

@ItamarTati
Copy link
Author

Thanks! Looks like a good start, I will probably merge it and mess around with it.

Sorry for not mentioning before, but can you make sure you're okay with the license and sign the CLA? https://github.com/zengm-games/zengm/tree/master#license-and-contributor-license-agreement

I sent an email agreeing to the terms and explaining my current situation.

If you need any help merging it in feel free to message me :)

@ItamarTati
Copy link
Author

@dumbmatter do you still want to merge this in, do you need any help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants