Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ rename tag label to subject #344

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

thibaudbrault
Copy link
Contributor

No description provided.

@thibaudbrault thibaudbrault changed the base branch from main to adminCertif May 24, 2023 10:33
Copy link
Contributor

@hgwood hgwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense qu'en toute logique on devrait aussi renommer le type TagCategory en SubjectCategory.

server/prisma/datamodel.graphql Outdated Show resolved Hide resolved
server/prisma/datamodel.graphql Outdated Show resolved Hide resolved
server/prisma/datamodel.graphql Outdated Show resolved Hide resolved
server/prisma/datamodel.graphql Outdated Show resolved Hide resolved
@hgwood hgwood changed the title Label to subject ♻️ rename tag label to subject Jun 8, 2023
@thibaudbrault thibaudbrault changed the base branch from adminCertif to main June 8, 2023 14:24
specialists: [User!]! @relation(name: "UserSpecialties", link: TABLE)

order: Int!
category: TagCategory! @relation(name: "TagLabelsCategory", link: TABLE)
category: SubjectCategory! @relation(name: "TagLabelsCategory", link: TABLE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le nom de la relation doit changer aussi, pour être cohérent

@@ -166,7 +166,7 @@ type Configuration {
slackCommandKey: String

tags: Json
tagCategories: [TagCategory!]! @relation(name: "ConfigurationTags", onDelete: CASCADE)
subjectCategories: [SubjectCategory!]! @relation(name: "ConfigurationTags", onDelete: CASCADE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le nom de la relation doit changer aussi, pour être cohérent

@hgwood hgwood marked this pull request as ready for review June 8, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants