remove python 3.8 support

zenml-io · Sep 23, 2024 · cabcd77 · cabcd77
1 parent 8c2a9e7
commit cabcd77
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 30 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -25,7 +25,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
       fail-fast: false
     uses: ./.github/workflows/setup-python-environment.yml
     with:
@@ -38,7 +38,7 @@ jobs:
     strategy:
       matrix:
         os: [windows-latest]
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
       fail-fast: false
     uses: ./.github/workflows/setup-python-environment.yml
     with:
@@ -51,7 +51,7 @@ jobs:
     strategy:
       matrix:
         os: [macos-latest]
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
       fail-fast: false
     uses: ./.github/workflows/setup-python-environment.yml
     with:
@@ -64,7 +64,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
       fail-fast: false
     uses: ./.github/workflows/lint-unit-test.yml
     with:
@@ -77,7 +77,7 @@ jobs:
     strategy:
       matrix:
         os: [windows-latest]
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
       fail-fast: false
     uses: ./.github/workflows/lint-unit-test.yml
     with:
@@ -90,7 +90,7 @@ jobs:
     strategy:
       matrix:
         os: [macos-latest]
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
       fail-fast: false
     uses: ./.github/workflows/lint-unit-test.yml
     with:

diff --git a/.github/workflows/lint-unit-test.yml b/.github/workflows/lint-unit-test.yml
@@ -32,13 +32,12 @@ on:
         description: 'Python version'
         type: choice
         options:
-          - '3.8'
           - '3.9'
           - '3.10'
           - '3.11'
           - '3.12'
         required: false
-        default: '3.8'
+        default: '3.9'
       enable_tmate:
         description: 'Enable tmate session for debugging'
         type: choice
@@ -86,20 +85,8 @@ jobs:
 
       - name: Docstring check
         run: bash scripts/docstring.sh
-        # Only run the docstring check on ubuntu-latest and python 3.8
-        if: ${{ inputs.os == 'ubuntu-latest' && inputs.python-version == '3.8' }}
-
-    #   - name: Markdown link check
-    #     uses: gaurav-nelson/github-action-markdown-link-check@v1
-    #     with:
-    #       use-quiet-mode: 'yes'
-    #       use-verbose-mode: 'no'
-    #       folder-path: './examples, ./docs/book, ./src'
-    #       file-path: './README.md, ./LICENSE, ./RELEASE_NOTES.md, CODE-OF-CONDUCT.md, CONTRIBUTING.md, CLA.md, RELEASE_NOTES.md, ROADMAP.md'
-    #       config-file: .github/workflows/markdown_check_config.json
-    #     continue-on-error: true
-    #     # Only run the markdown link check on ubuntu-latest and python 3.8
-    #     if: ${{ inputs.os == 'ubuntu-latest' && inputs.python-version == '3.8' }}
+        # Only run the docstring check on ubuntu-latest and python 3.9
+        if: ${{ inputs.os == 'ubuntu-latest' && inputs.python-version == '3.9' }}
 
       - name: Run unit tests
         run: |

diff --git a/.github/workflows/publish-pypi-package.yml b/.github/workflows/publish-pypi-package.yml
@@ -22,7 +22,7 @@ jobs:
       - name: Set up Python
         uses: actions/[email protected]
         with:
-          python-version: "3.8"
+          python-version: "3.9"
       - name: Install Poetry
         uses: snok/[email protected]
         with:

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -11,7 +11,7 @@ jobs:
     uses: ./.github/workflows/lint-unit-test.yml
     with:
       os: "ubuntu-latest"
-      python-version: "3.8"
+      python-version: "3.9"
     secrets: inherit
 
   # checks zenml and mlstacks can be installed together in same environment
@@ -25,7 +25,7 @@ jobs:
       - name: Set up Python
         uses: actions/setup-python@v2
         with:
-          python-version: "3.8"
+          python-version: "3.9"
 
       - name: Install current package as editable
         run: pip install -e .

diff --git a/pyproject.toml b/pyproject.toml
@@ -21,7 +21,6 @@ classifiers = [
     "Intended Audience :: System Administrators",
     "License :: OSI Approved :: Apache Software License",
     "Programming Language :: Python :: 3 :: Only",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
@@ -64,7 +63,7 @@ exclude = [
 ]
 
 [tool.poetry.dependencies]
-python = ">=3.8,<3.13"
+python = ">=3.9,<3.13"
 pydantic = { version = "~2.8" }
 pyyaml = { version = ">=6.0.1" }
 click = { version = "^8.0.1,<8.1.4" }
@@ -164,8 +163,8 @@ select = [
 ignore = ["COM812", "ISC001"]
 
 src = ["src", "tests"]
-# use Python 3.8 as the minimum version for autofixing
-target-version = "py38"
+# use Python 3.9 as the minimum version for autofixing
+target-version = "py39"
 ignore-init-module-imports = true
 # # Disable autofix for unused imports (`F401`).
 # unfixable = ["F401"]

diff --git a/tests/integration/docker-compose.localstack.yml b/tests/integration/docker-compose.localstack.yml
@@ -1,4 +1,4 @@
-version: "3.8"
+version: "3.9"
 
 services:
   localstack: