-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Huggingface model deployer support #157
base: develop
Are you sure you want to change the base?
Changes from 6 commits
2f145d8
77acb20
1eca041
3f7cac8
3fedc39
b634d36
21a6120
7296aa3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -31,6 +31,7 @@ class ComponentTypeEnum(str, Enum): | |||
FEATURE_STORE = "feature_store" | ||||
ANNOTATOR = "annotator" | ||||
IMAGE_BUILDER = "image_builder" | ||||
|
||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
|
||||
|
||||
class ComponentFlavorEnum(str, Enum): | ||||
|
@@ -50,6 +51,7 @@ class ComponentFlavorEnum(str, Enum): | |||
VERTEX = "vertex" | ||||
ZENML = "zenml" | ||||
DEFAULT = "default" | ||||
HUGGINGFACE = "huggingface" | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably insert this in the alphabetical order... |
||||
|
||||
|
||||
class DeploymentMethodEnum(str, Enum): | ||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -266,4 +266,4 @@ data "external" "get_cluster_auth" { | |
depends_on = [ | ||
aws_eks_cluster.cluster | ||
] | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,4 +9,4 @@ module "istio" { | |
] | ||
|
||
chart_version = local.istio.version | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,6 +64,14 @@ locals { | |
namespace = "seldon-system" | ||
workloads_namespace = "zenml-workloads-seldon" | ||
service_account_name = "seldon" | ||
} | ||
|
||
huggingface = { | ||
version = "4.41.3" | ||
name = "huggingface" | ||
namespace = "huggingface-system" | ||
workloads_namespace = "zenml-workloads-huggingface" | ||
service_account_name = "huggingface" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we don't need this? |
||
} | ||
|
||
zenml = { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -76,6 +76,13 @@ resource "local_file" "stack_file" { | |
flavor: seldon | ||
name: eks_seldon_model_deployer | ||
configuration: {"kubernetes_context": "${aws_eks_cluster.cluster[0].arn}", "kubernetes_namespace": "${local.seldon.workloads_namespace}", "base_url": "http://${module.istio[0].ingress-hostname}:${module.istio[0].ingress-port}"}} | ||
%{endif} | ||
%{if var.enable_model_deployer_huggingface} | ||
model_deployer: | ||
id: ${uuid()} | ||
flavor: huggingface | ||
name: eks_huggingface_model_deployer | ||
configuration: {"kubernetes_context": "${aws_eks_cluster.cluster[0].arn}", "kubernetes_namespace": "${local.huggingface.workloads_namespace}", "base_url": "http://${module.istio[0].ingress-hostname}:${module.istio[0].ingress-port}"}} | ||
Comment on lines
+84
to
+85
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needs updating as we're no longer using EKS for this etc.. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @strickvl Thank you for the review! I understood everything else but for this part, Could you please provide more guidance or resources on how to do this part? |
||
%{endif} | ||
ADD | ||
filename = "./aws_modular_stack_${replace(substr(timestamp(), 0, 16), ":", "_")}.yaml" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same theme here... we're not using a cluster any more for the HF deployment so no need to include all that stuff here.. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,4 +9,4 @@ module "istio" { | |
] | ||
|
||
chart_version = local.istio.version | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,4 +54,4 @@ module "vpc" { | |
next_hop_internet = "true" | ||
}, | ||
] | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,4 +8,4 @@ module "istio" { | |
] | ||
|
||
chart_version = local.istio.version | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -100,4 +100,4 @@ resource "k3d_cluster" "zenml-cluster" { | |
depends_on = [ | ||
k3d_registry.zenml-registry, | ||
] | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,4 +37,4 @@ resource "kubernetes_namespace" "k8s-workloads" { | |
depends_on = [ | ||
k3d_cluster.zenml-cluster, | ||
] | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,4 +47,4 @@ resource "minio_s3_bucket" "zenml_bucket" { | |
module.nginx-ingress, | ||
module.istio, | ||
] | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,4 +48,4 @@ resource "minio_s3_bucket" "mlflow_bucket" { | |
module.nginx-ingress, | ||
module.istio, | ||
] | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,4 +10,4 @@ module "nginx-ingress" { | |
] | ||
|
||
chart_version = local.nginx_ingress.version | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -350,4 +350,4 @@ environments: | |
%{endif} | ||
ADD | ||
filename = "./k3d_test_framework_cfg.yaml" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.