fix for recent model changes (#42)

zenml-io · Oct 9, 2024 · b8f0580 · b8f0580
1 parent 8e987c8
commit b8f0580
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -57,5 +57,5 @@ jobs:
         with:
           stack-name: ${{ matrix.stack-name }}
           python-version: ${{ matrix.python-version }}
-          ref-zenml: ${{ inputs.ref-zenml || 'feature/PRD-566-dependency-cleanup' }}
+          ref-zenml: ${{ inputs.ref-zenml || 'bugfix/PRD-653-fix-models-linkage' }}
           ref-template: ${{ inputs.ref-template || github.ref }}
diff --git a/...% if metric_compare_promotion %}compute_performance_metrics_on_current_data.py{% endif %} b/...% if metric_compare_promotion %}compute_performance_metrics_on_current_data.py{% endif %}
@@ -46,7 +46,10 @@ def compute_performance_metrics_on_current_data(
     current_version = Model(name=latest_version.name, version=target_env)
 
     latest_version_number = latest_version.number
-    current_version_number = current_version.number
+    try:
+        current_version_number = current_version.number
+    except KeyError:
+        current_version_number = None
 
     if current_version_number is None:
         current_version_number = -1

diff --git a/...teps/promotion/{% if metric_compare_promotion %}promote_with_metric_compare.py{% endif %} b/...teps/promotion/{% if metric_compare_promotion %}promote_with_metric_compare.py{% endif %}
@@ -47,7 +47,10 @@ def promote_with_metric_compare(
     latest_version = get_step_context().model
     current_version = Model(name=latest_version.name, version=target_env)
 
-    current_version_number = current_version.number
+    try:
+        current_version_number = current_version.number
+    except KeyError:
+        current_version_number = None
 
     if current_version_number is None:
         logger.info("No current model version found - promoting latest")