Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embeddings finetuning #124

Merged
merged 121 commits into from
Aug 8, 2024
Merged

Embeddings finetuning #124

merged 121 commits into from
Aug 8, 2024

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented Aug 7, 2024

No description provided.

@strickvl strickvl added enhancement New feature or request internal labels Aug 7, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

gitguardian bot commented Aug 7, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13307821 Triggered Generic High Entropy Secret a5ced95 llm-complete-guide/notebooks/argilla_embeddings.ipynb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@strickvl strickvl marked this pull request as draft August 7, 2024 18:27
@strickvl strickvl marked this pull request as ready for review August 8, 2024 08:19
Copy link
Contributor

@AlexejPenner AlexejPenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@strickvl strickvl merged commit a0eee84 into main Aug 8, 2024
1 of 3 checks passed
@strickvl strickvl deleted the feature/finetune-embeddings branch August 8, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants