Use QDoRA instead of just LoRA #128
Open
+84
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strickvl
changed the title
strickvl
commented
Aug 22, 2024
Comment on lines
+23
to
+28
| from peft import ( | ||
| LoraConfig, | ||
| LoraRuntimeConfig, | ||
| get_peft_model, | ||
| prepare_model_for_kbit_training, | ||
| ) |
strickvl
commented
Aug 22, 2024
Comment on lines
+101
to
+102
| use_dora=True, | ||
| runtime_config=LoraRuntimeConfig(ephemeral_gpu_offload=True), |
There was a problem hiding this comment.
I added these two lines
htahir1
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses QDoRA instead of just LoRA. This has some efficiency benefits, notably faster training without a corresponding performance loss. See this for more details.
The code on the base branch was also unformatted, but (aside from formatting changes) I've highlighted the specific lines where I've actually changed code.