Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for 0.65.0 #129

Merged
merged 1 commit into from
Sep 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions llm-lora-finetuning/pipelines/train_accelerated.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,12 @@

from steps import (
evaluate_model,
finetune,
finetune_accelerated,
prepare_data,
promote,
log_metadata_from_step_artifact,
)
from zenml import pipeline
from zenml.integrations.huggingface.steps import run_with_accelerate


@pipeline
Expand Down Expand Up @@ -74,7 +73,7 @@ def llm_peft_full_finetune(
id="log_metadata_evaluation_base"
)

ft_model_dir = run_with_accelerate(finetune)(
ft_model_dir = finetune_accelerated(
base_model_id=base_model_id,
dataset_dir=datasets_dir,
use_fast=use_fast,
Expand Down
2 changes: 1 addition & 1 deletion llm-lora-finetuning/steps/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#

from .evaluate_model import evaluate_model
from .finetune import finetune
from .finetune import finetune, finetune_accelerated
from .prepare_datasets import prepare_data
from .promote import promote
from .log_metadata import log_metadata_from_step_artifact
4 changes: 4 additions & 0 deletions llm-lora-finetuning/steps/finetune.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
from zenml.materializers import BuiltInMaterializer
from zenml.utils.cuda_utils import cleanup_gpu_memory
from zenml.client import Client
from zenml.integrations.huggingface.steps import run_with_accelerate

logger = get_logger(__name__)

Expand Down Expand Up @@ -184,3 +185,6 @@ def finetune(
)

return ft_model_dir


finetune_accelerated = run_with_accelerate(finetune, num_processes=2, multi_gpu=True, mixed_precision="bf16")
Loading