Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upgrade customer satisfaction #84

Merged
merged 13 commits into from
Dec 22, 2023

Conversation

AlexejPenner
Copy link
Collaborator

@AlexejPenner AlexejPenner commented Dec 21, 2023

This works now, although i would be happy to get some feedback on best preactices. Especially the continuous deployment pipelineis something I have doubts about.

Because the first step of this pipeline is the training pipeline, I had issues getting the ModelVersion that was in the Production Stage rather than the model trained by the first pipeline.

@AlexejPenner AlexejPenner requested a review from htahir1 December 21, 2023 02:13
Copy link

dagshub bot commented Dec 21, 2023

Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a once over, but looks good!

customer-satisfaction/README.md Show resolved Hide resolved
customer-satisfaction/config.yaml Outdated Show resolved Hide resolved
customer-satisfaction/config.yaml Outdated Show resolved Hide resolved
customer-satisfaction/model/evaluator.py Show resolved Hide resolved
customer-satisfaction/steps/evaluation.py Outdated Show resolved Hide resolved
customer-satisfaction/pipelines/training_pipeline.py Outdated Show resolved Hide resolved
customer-satisfaction/steps/train_model.py Outdated Show resolved Hide resolved
customer-satisfaction/pipelines/utils.py Outdated Show resolved Hide resolved
customer-satisfaction/pipelines/utils.py Outdated Show resolved Hide resolved
customer-satisfaction/steps/model_loader.py Show resolved Hide resolved
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README reviewed

customer-satisfaction/README.md Outdated Show resolved Hide resolved
customer-satisfaction/README.md Outdated Show resolved Hide resolved
customer-satisfaction/README.md Outdated Show resolved Hide resolved
customer-satisfaction/README.md Show resolved Hide resolved
@AlexejPenner
Copy link
Collaborator Author

@htahir1 feel free to merge when you agree :)

@htahir1 htahir1 merged commit 1d24077 into main Dec 22, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants