Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Lightning Orchestrator (remove -y from pip install) #3058

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fix Lightning Orchestrator (remove -y from pip install) #3058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/zenml/integrations/lightning/orchestrators/lightning_orchestrator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ def _construct_lightning_steps(
f"Installing requirements: {pipeline_requirements_to_string}"
)
studio.run(f"uv pip install {pipeline_requirements_to_string}")
studio.run("pip install zenml -y")
studio.run("pip install zenml")

for custom_command in settings.custom_commands or []:
studio.run(
Expand Down Expand Up @@ -493,7 +493,7 @@ def _upload_and_run_pipeline(
)
studio.run("pip install uv")
studio.run(f"uv pip install {requirements}")
studio.run("pip install zenml -y")
studio.run("pip install zenml")
# studio.run(f"pip install {wheel_path.rsplit('/', 1)[-1]}")
for command in settings.custom_commands or []:
output = studio.run(
Expand Down Expand Up @@ -566,7 +566,7 @@ def _run_step_in_new_studio(
)
studio.run("pip install uv")
studio.run(f"uv pip install {details['requirements']}")
studio.run("pip install zenml -y")
studio.run("pip install zenml")
# studio.run(f"pip install {wheel_path.rsplit('/', 1)[-1]}")
for command in custom_commands or []:
output = studio.run(
Expand Down
4 changes: 2 additions & 2 deletions src/zenml/integrations/lightning/orchestrators/lightning_orchestrator_entrypoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ def main() -> None:
f"uv pip install {pipeline_requirements_to_string}"
)
logger.info(output)
output = main_studio.run("pip install zenml -y")
output = main_studio.run("pip install zenml")
logger.info(output)

for command in pipeline_settings.custom_commands or []:
Expand Down Expand Up @@ -248,7 +248,7 @@ def run_step_on_lightning_studio(step_name: str) -> None:
f"uv pip install {step_requirements_to_string}"
)
logger.info(output)
output = studio.run("pip install zenml -y")
output = studio.run("pip install zenml")
logger.info(output)
for command in step_settings.custom_commands or []:
output = studio.run(
Expand Down
Loading