boards: xtensa: docs: rimage is no more a separate git repository #66307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix intel_adsp_generic.rst following the merge of the rimage git repository back into the sof git repository: - thesofproject/sof#7270 Signed-off-by: Marc Herbert <[email protected]>
zephyrbot
requested review from
aborisovich,
andyross,
ceolin,
dcpleung,
jxstelter,
kv2019i,
lgirdwood,
lyakh,
marcinszkudlinski,
nashif,
softwarecki and
tmleman
kartben
approved these changes
Dec 8, 2023
| build.cmake-args -- -DRIMAGE_CONFIG_PATH=/path/to/source/rimage/config``. | ||
| Platform-specific configuration files are located in the ``rimage/config/`` | ||
| subdirectory. For a different configuration directory you can use: | ||
| ``west config build.cmake-args -- -DRIMAGE_CONFIG_PATH=/path/to/my/rimage/config``. |
There was a problem hiding this comment.
not really a request for change but just a nice Sphinx tip for literal text with "variable" parts, which you may look at using in the future:
Suggested change
| ``west config build.cmake-args -- -DRIMAGE_CONFIG_PATH=/path/to/my/rimage/config``. | |
| :samp:`west config build.cmake-args -- -DRIMAGE_CONFIG_PATH={/path/to/my/rimage/config}`. |
https://www.sphinx-doc.org/en/master/usage/restructuredtext/roles.html#role-samp
There was a problem hiding this comment.
Thanks and sorry I'm seeing your suggestion only now - drown in other Github notifications as usual!
softwarecki
approved these changes
Dec 8, 2023
nashif
approved these changes
Dec 8, 2023
dcpleung
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix intel_adsp_generic.rst following the merge of the rimage git repository back into the sof git repository: